Cevaplanmadı Player vs player

[qay123]

Türkiye'de ilk Mobil & PC Aynı Anda Metin2 Oyna. Triarchonline kalıcı ve uzun ömürlü yapısı ile 24 Temmuz'da açılıyor. | 1-99 Mobil Metin2 Triarch HEMEN TIKLA!

@gpackg Yes i too.

 

[qay123]

Comment this section and try again please

#ifdef NEW_ICEDAMAGE_SYSTEM
    if (!battle_is_icedamage(ch, victim))
        return false;
#endif

I've seen that you implemented a new system called new_ice_damage_system but check the conditions probably this function is returning false somewhere in the second if statement.

pAttacker && pAttacker-IsPC()) these conditions are true so we continue race=? warrior race probably 1 or 2 depending on the gender not sure what you did in the rest since there were no comments but If you want to apply this ice damage only to MOBS(npcs) change your statement in battle_is_attackable to if(victim->IsNPC()) //do stuff

#ifdef NEW_ICEDAMAGE_SYSTEM
bool battle_is_icedamage(LPCHARACTER pAttacker, LPCHARACTER pVictim)
{
    if (pAttacker && pAttacker->IsPC())
    {
        DWORD race = pAttacker->GetRaceNum();
        const DWORD tmp_dwNDRFlag = pVictim->GetNoDamageRaceFlag();
        if (tmp_dwNDRFlag &&
            (race < MAIN_RACE_MAX_NUM) &&
            (IS_SET(tmp_dwNDRFlag, 1<<race))
        )
        {
            return false;
        }
        const std::set<DWORD> & tmp_setNDAFlag = pVictim->GetNoDamageAffectFlag();
        if (tmp_setNDAFlag.size())
        {
            for (std::set<DWORD>::iterator it = tmp_setNDAFlag.begin(); it != tmp_setNDAFlag.end(); ++it)
            {
                if (!pAttacker->IsAffectFlag(*it))
                {
                    return false;
                }
            }
        }
    }
    return true;
}
#endif

This system was here I don´t know what doing this system
So how your advice?
Change this: bool battle_is_icedamage(LPCHARACTER pAttacker, LPCHARACTER pVictim)
at this : bool battle_is_icedamage if(victim->IsNPC())

Or some other advice?

 

[Agora Metin2]

#ifdef NEW_ICEDAMAGE_SYSTEM
if (!battle_is_icedamage(ch, victim))
return false;
#endif

comment this section

*/
#ifdef NEW_ICEDAMAGE_SYSTEM
if (!battle_is_icedamage(ch, victim))
return false;
#endif
*/

and rebuild your game

 

[qay123]

#ifdef NEW_ICEDAMAGE_SYSTEM
if (!battle_is_icedamage(ch, victim))
return false;
#endif

comment this section

*/
#ifdef NEW_ICEDAMAGE_SYSTEM
if (!battle_is_icedamage(ch, victim))
return false;
#endif
*/

and rebuild your game

I don´t know who wrote this code.
I don´t know what this system doing.
I do not want debug mode for me

 

[Agora Metin2]

I don´t know who wrote this code.
I don´t know what this system doing.

I’m telling you to comment out this code not asking if you’ve wrote this code or not just comment it and try again

 

[qay123]

I’m telling you to comment out this code not asking if you’ve wrote this code or not just comment it and try again

I know now.
I can´t attack in city.
I can attack player vs player in others place.