Cevaplanmadı Player vs player

[qay123]

Türkiye'de ilk Mobil & PC Aynı Anda Metin2 Oyna. Triarchonline kalıcı ve uzun ömürlü yapısı ile 24 Temmuz'da açılıyor. | 1-99 Mobil Metin2 Triarch HEMEN TIKLA!

@gpackg Yes i too.

 

[Agora Metin2]

upload your battle.cpp & input_main.cpp and let us have a look at them

also are you using one of the public files? do you have bot control system? maybe bad flagging ending up to misses? is it always happening?

 

[qay123]

upload your battle.cpp & input_main.cpp and let us have a look at them

also are you using one of the public files? do you have bot control system? maybe bad flagging ending up to misses? is it always happening?

No i don´t have bot control system.
Yes public files.
https://easyupload.io/xdidz2 - battle.cpp
https://easyupload.io/95bwmv - nput_main.cpp

 

[Agora Metin2]

Comment this section and try again please

#ifdef NEW_ICEDAMAGE_SYSTEM
    if (!battle_is_icedamage(ch, victim))
        return false;
#endif

I've seen that you implemented a new system called new_ice_damage_system but check the conditions probably this function is returning false somewhere in the second if statement.

pAttacker && pAttacker-IsPC()) these conditions are true so we continue race=? warrior race probably 1 or 2 depending on the gender not sure what you did in the rest since there were no comments but If you want to apply this ice damage only to MOBS(npcs) change your statement in battle_is_attackable to if(victim->IsNPC()) //do stuff

#ifdef NEW_ICEDAMAGE_SYSTEM
bool battle_is_icedamage(LPCHARACTER pAttacker, LPCHARACTER pVictim)
{
    if (pAttacker && pAttacker->IsPC())
    {
        DWORD race = pAttacker->GetRaceNum();
        const DWORD tmp_dwNDRFlag = pVictim->GetNoDamageRaceFlag();
        if (tmp_dwNDRFlag &&
            (race < MAIN_RACE_MAX_NUM) &&
            (IS_SET(tmp_dwNDRFlag, 1<<race))
        )
        {
            return false;
        }
        const std::set<DWORD> & tmp_setNDAFlag = pVictim->GetNoDamageAffectFlag();
        if (tmp_setNDAFlag.size())
        {
            for (std::set<DWORD>::iterator it = tmp_setNDAFlag.begin(); it != tmp_setNDAFlag.end(); ++it)
            {
                if (!pAttacker->IsAffectFlag(*it))
                {
                    return false;
                }
            }
        }
    }
    return true;
}
#endif

 

[Agora Metin2]

If you want to make a debug mode for yourself change your code and add some logs or error statements

if (!battle_is_icedamage(ch, victim))
return false;
#endif

to

if (!battle_is_icedamage(ch, victim))
sys_log(0, "this is not an ice damage!")
return false;
#endif

and see whenever you hit an enemy this syslog appears in your syslog.txt file

if yes you gotta check your function or make it work only for mobs

    if (!battle_is_icedamage(ch, victim) && victim->IsNPC())
            sys_log(0, "this is not an ice damage! and this function only work for mobs")
        return false;
#endif