Fix overflow Martysama GMHosts - Grzyb

[muchomor1337]

HERAKLES Otomatik Avlı kalıcı sunucu. 19 Haziran'da açılıyor. Atius & Wizard güvencesiyle hemen kayıt ol, ön kayıt ödülleri aktif. HEMEN TIKLA!

Hello, today we will fix a bug that occurs on every Martysama

Error code:

READ of size 16 at 0x2223ea1c thread T0
    #1 0x6af0b9 in buffer_write(buffer*&, void const*, int) /home/moje/libthecore/src/buffer.c:167:2
    #2 0x67da99 in CPeerBase::Encode(void const*, unsigned int) /home/moje/db/src/PeerBase.cpp:157:2
    #3 0x565204 in CClientManager::QUERY_BOOT(CPeer*, SPacketGDBoot*) /home/moje/db/src/ClientManager.cpp:466:9
    #4 0x582992 in CClientManager::ProcessPackets(CPeer*) /home/moje/db/src/ClientManager.cpp:2352:5
    #5 0x562fe4 in CClientManager::Process() /home/moje/db/src/ClientManager.cpp:3260:6
    #6 0x5607a5 in CClientManager::MainLoop() /home/moje/db/src/ClientManager.cpp:250:8
    #7 0x666bde in main /home/moje/db/src/Main.cpp:99:29

[Fix]
Find in Clientmanager.cpp

    peer->EncodeWORD(16);
    peer->EncodeWORD(vHost.size());

    for (size_t n = 0; n < vHost.size(); ++n)
    {
        peer->Encode(vHost[n].c_str(), 16);
        sys_log(0, "GMHosts %s", vHost[n].c_str());
    }

Change:

    peer->EncodeWORD(16);
    peer->EncodeWORD(vHost.size());

    for (size_t n = 0; n < vHost.size(); ++n)
    {
        const char* host = vHost[n].c_str();

        char hostBuffer[16] = {0};
        std::strncpy(hostBuffer, host, sizeof(hostBuffer) - 1);

        peer->Encode(hostBuffer, sizeof(hostBuffer));
        sys_log(0, "GMHosts %s", host);
    }

 

[TrC22]

I haven't had this problem on any server.

 

[muchomor1337]

I haven't had this problem on any server.

it is only there booting server
normal player will do nothing, I have a tool that detects leaks and when starting the server it is here