ShopEx Buffer Overflow Fix

[Luigina]

Hello community !

I found an issue when i was checking ShopEx system. If your pack_tab size is bigger than default m2 / SHOP_HOST_ITEM_MAX_NUM is bigger than default this overflow occurs.
This causes a core crash as seen in the screenshot below:

Linkleri görebilmek için Turkmmo Forumuna ÜYE olmanız gerekmektedir.

Solution

I use temp buffer for handle better but you can change 8096 too.

To solve this problem, you can follow these steps:

// In shopEx.cpp

--------------------------------------------------------------
// Search

    char temp[8096];
    char* buf = &temp[0];
    size_t size = 0;

// Change like this

    TEMP_BUFFER buf(16 * 1024);
--------------------------------------------------------------
// Search

        memcpy(buf, &pack_tab, sizeof(pack_tab));
        buf += sizeof(pack_tab);
        size += sizeof(pack_tab);

// Change like this

        buf.write(&pack_tab, sizeof(pack_tab));
--------------------------------------------------------------
// Search

    pack.size = sizeof(pack) + sizeof(pack2) + size;

// Change like this

    pack.size = sizeof(pack) + sizeof(pack2) + buf.size();
--------------------------------------------------------------
// Search
 
    ch->GetDesc()->Packet(temp, size);

// Change like this


    ch->GetDesc()->Packet(buf.read_peek(), buf.size());

After following these steps, you should have overcome this problem in the ShopEx system. If you have any problems, please leave a comment.

Kind regards,

Luigina

 

[HarunKocer]

teşekkürler berkay

 

[Luigina]

teşekkürler berkay

rica ederim

 

[recepk78]

Teşekkürler cano

 

[cb4wtu]

Eline sağlık