FIX Observer Enemy Guild under Map War

[Rakancito]

HERAKLES Otomatik Avlı kalıcı sunucu. 19 Haziran'da açılıyor. Atius & Wizard güvencesiyle hemen kayıt ol, ön kayıt ödülleri aktif. HEMEN TIKLA!

It's very simple, I suppose some must already have FIX but most do not.

When you give Guild War Under Map if an Observer from your guild enters War and the enemy kills it, the counter will count it causing you to lose the war if they are many observers., although it can only kill you once, it continues to be an advantage.

Search in battle.cpp

bool battle_is_attackable(LPCHARACTER ch, LPCHARACTER victim)
{
    if (victim->IsDead())
        return false;

after this add:

    if (victim->IsObserverMode())
        return false;

 

[Robson Oliboni]

beautiful correction thank you.

 

[salihq]

thanks for sharing

 

[Tunga]

its should like this for sure
bool battle_is_attackable(LPCHARACTER ch, LPCHARACTER victim)
{
if (victim->IsDead() || victim->IsObserverMode())
return false;
if (ch->IsStun() || ch->IsDead() || ch->IsObserverMode())
return false;
.
.
.
.

 

[Rakancito]

its should like this for sure
bool battle_is_attackable(LPCHARACTER ch, LPCHARACTER victim)
{
if (victim->IsDead() || victim->IsObserverMode())
return false;
if (ch->IsStun() || ch->IsDead() || ch->IsObserverMode())
return false;
.
.
.
.

The "||" they are as "if" you put a different "if", I don't understand why repeat so many IsDead, the correct thing with yours would be.

bool battle_is_attackable(LPCHARACTER ch, LPCHARACTER victim)

{

    if (victim->IsDead() || victim->IsObserverMode() || ch->IsStun() )
      return false;

No need to place as much control

An

if (condition1 || condition2)

equals

if (condition1) {
...
}
if (condition2) {
...
}

An

if (condition1 && condition2)

equals

if (condition1) {
        if (condition2) {
                    ...
       }
}