CreateWhisper fix memory leak

[banzai2]

Türkiye'nin ilk OldSchool MOBİL 1-99 Sunucusu Sezar2 9 Ekim'de Açılıyor! Rekor Açılışı Kaçırma! HEMEN TIKLA!

std::insert() does nothing when the key already exists. So every time CreateWhisper was called for an existing name (e.g. reopening a whisper window), a new CWhisper was allocated but never stored in the map and never freed — classic memory leak.

CWhisper * CPythonChat::CreateWhisper(const char * c_szName)
{
    CWhisper * pWhisper = CWhisper::New();
    m_WhisperMap.insert(TWhisperMap::value_type(c_szName, pWhisper));
    return pWhisper;
}

CWhisper * CPythonChat::CreateWhisper(const char * c_szName)
{
    TWhisperMap::iterator itor = m_WhisperMap.find(c_szName);
    if (itor != m_WhisperMap.end())
        return itor->second;

    CWhisper * pWhisper = CWhisper::New();
    m_WhisperMap.insert(TWhisperMap::value_type(c_szName, pWhisper));
    return pWhisper;
}

 

[ɑce]